William Scott played football for Forfar Athletic. In 1888 he moved to London to work at Royal Arsenal in Woolwich, one of the government's main munition factories.

Barbour made his debut for Woolwich Arsenal in the 1888-89 season. He joined a team that included J. M. Charteris, Peter Connolly, David Danskin, Richard Horsington, Fred Beardsley, Joseph Bates, Humphrey Babour and John McBean.

Woolwich Arsenal continued to make good progress and won the London Charity Cup in 1890. During his time at the club, Scott, an outside left, scored 28 goals in 42 games.