James Marshall played for Shettleston Juniors before qualifying as a doctor. He joined Glasgow Rangers and during his time at the club won six Scottish League Championship medals (1927, 1929, 1930, 1931, 1933, and 1934). He also won three Scottish Cup winners' medals (1930, 1932 and 1934) and three international caps (1932-34). While playing for the Rangers he had a average of over a goal every two games. Marshall moved to Arsenal in 1934. He only played four games for his new club before moving onto West Ham United. He was a regular in the team before being replaced by Archie Macaulay who was purchased from Glasgow Rangers for £3,500. After leaving West Ham, Dr. James Marshall worked in Bermondsey.